Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Lint markdown in the CI #30395

Merged
merged 4 commits into from
Jan 7, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Dec 25, 2021

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation test labels Dec 25, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 25, 2021

No bundle size changes

Generated by 🚫 dangerJS against 18f989f

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Let's try it out.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Dec 27, 2021

I will wait for feedback on mui/mui-x#3504 from X before moving forward.
It caught a number of issues that I have been manually raising in the past, I'm pretty happy with the tool so far. It only takes 6s of time in the CI.

@flaviendelangle
Copy link
Member

Approved on X

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 5, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 7, 2022
@oliviertassinari oliviertassinari changed the title [docs] Prevent common markdown mistakes [docs] Lint markdown in the CI Jan 7, 2022
@oliviertassinari oliviertassinari merged commit 1b05b0b into mui:master Jan 7, 2022
@oliviertassinari oliviertassinari deleted the markdown-lint branch January 7, 2022 16:21
wladimirguerra pushed a commit to wladimirguerra/material-ui that referenced this pull request Feb 2, 2022
@@ -0,0 +1,26 @@
{
Copy link
Member Author

@oliviertassinari oliviertassinari Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we could look into how to make it a JavaScript file so that the same configuration can be shared with other repositories rather than copied & pasted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants